<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)"" href="https://bugs.freedesktop.org/show_bug.cgi?id=91967#c32">Comment # 32</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)"" href="https://bugs.freedesktop.org/show_bug.cgi?id=91967">bug 91967</a> from <a class="email" href="mailto:b.harrington@samsung.com" title="Bryce Harrington <b.harrington@samsung.com>"> Bryce Harrington</a> <pre>I can quibble over patch style but the fix seems on the right path - don't destroy image->base if it wasn't created or was already destroyed. What I'm not sure about is adding a second goto bail out point in the code. There are situations where bail outs are appropriate and add clarity to the code, but this routine is so convoluted already I don't think that would be the case here. What about setting "image = NULL" after the destruction and then just adding an "if (image)" before the cairo_surface_destroy call in BAIL?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>