<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:psychon@znc.in" title="Uli Schlachter <psychon@znc.in>"> <span class="fn">Uli Schlachter</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)""
href="https://bugs.freedesktop.org/show_bug.cgi?id=91967">bug 91967</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #118325 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)""
href="https://bugs.freedesktop.org/show_bug.cgi?id=91967#c43">Comment # 43</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)""
href="https://bugs.freedesktop.org/show_bug.cgi?id=91967">bug 91967</a>
from <span class="vcard"><a class="email" href="mailto:psychon@znc.in" title="Uli Schlachter <psychon@znc.in>"> <span class="fn">Uli Schlachter</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=124589" name="attach_124589" title="Proposed fix">attachment 124589</a> <a href="attachment.cgi?id=124589&action=edit" title="Proposed fix">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=91967&attachment=124589'>[review]</a>
Proposed fix
Before this goes even more out of control: Anybody against this patch?
It should make Chris happy by saying that the caller still did something wrong
here, having the drawable freed from beneath cairo.
It should Bryce happy, because the possible-crash he worries about is handled.
Note that freeing both image and &image->base as proposed in <a href="show_bug.cgi?id=91967#c6">comment 6</a> is
wrong, since &image->base is just a hidden pointer cast. Image is the
cairo_image_surface_t* and &image->base is the same thing as a
cairo_surface_t*.
It should make most reporters happy since it fixes the
double-cairo_surface_destroy that this book actually is about (sorry Jaroslav,
cairo is currently not meant to handle this case and your patch is incomplete
due to X11's asynchronous nature).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>