<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:ranma42@gmail.com" title="Andrea Canciani <ranma42@gmail.com>"> <span class="fn">Andrea Canciani</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [Patch] Cairo potentially spams stdout in certain places"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95227">bug 95227</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>chris@chris-wilson.co.uk
</td>
<td>ranma42@gmail.com
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEEDINFO
</td>
<td>ASSIGNED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [Patch] Cairo potentially spams stdout in certain places"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95227#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - [Patch] Cairo potentially spams stdout in certain places"
href="https://bugs.freedesktop.org/show_bug.cgi?id=95227">bug 95227</a>
from <span class="vcard"><a class="email" href="mailto:ranma42@gmail.com" title="Andrea Canciani <ranma42@gmail.com>"> <span class="fn">Andrea Canciani</span></a>
</span></b>
<pre>(In reply to Darxus from <a href="show_bug.cgi?id=95227#c3">comment #3</a>)
<span class="quote">> Filenames and line numbers that are doing this?</span >
You can find those in the diff file:
src/cairo-debug.c:265
src/cairo-pattern.c:4610,4617
src/cairo-surface-observer.c:1222
<span class="quote">>
> How to reproduce it?</span >
I did not check throughly, but I am pretty confident that the issue in the
first file would only be visible when compiling cairo with TRACE-ing enabled
(manually, in src/cairoint.h), that is unusual and only meant for debugging.
The bugs in src/cairo-pattern.c would not be visible without some significant
changes, as all of the _cairo_debug_print_*pattern() functions are currently
dead code. Again, they are meant as an aid when debugging cairo itself and are
not (or at least should not be) exposed through the public API.
The last one looks like a genuine bug that can easily be triggered:
#include <cairo.h>
int
main (int argc, char *argv[])
{
cairo_surface_t *image = cairo_image_surface_create (CAIRO_FORMAT_ARGB32,
32, 32);
cairo_surface_t *surface = cairo_surface_create_observer (image,
CAIRO_SURFACE_OBSERVER_NORMAL);
cairo_surface_mark_dirty (surface);
cairo_surface_destroy (surface);
cairo_surface_destroy (image);
return 0;
}
All of the changes look good to me (the first two in order to improve
debugging, the last one as an actual bug fix). Only nit is I would also remove
one of the two consecutive blank lines in the change for
cairo-surface-observer.c ;)
If nobody raises concerns about the patch, I will merge it in the weekend.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>