<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Add a way to specify units" href="https://bugs.freedesktop.org/show_bug.cgi?id=90166#c9">Comment # 9</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add a way to specify units" href="https://bugs.freedesktop.org/show_bug.cgi?id=90166">bug 90166</a> from <a class="email" href="mailto:spitzak@gmail.com" title="Bill Spitzak <spitzak@gmail.com>"> Bill Spitzak</a> <pre><a href="show_bug.cgi?id=90166#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add a way to specify units" href="show_bug.cgi?id=90166">bug 90166</a> from Adrian Johnson The proposed api in this bug <a class="bz_bug_link bz_status_NEW " title="NEW - Add a way to specify units" href="show_bug.cgi?id=90166">https://bugs.freedesktop.org/show_bug.cgi?id=90166</a> uses an enumeration for each of the svg unit types, but nothing is ever done with that enumeration other than to print a 2-letter string into the svg output. I propose a better api would be to just accept the string and print it without any checking. This would remove the need to modify cairo on any svg updates that add new units, and also probably makes it much easier to copy the units from one svg to another. Proposed api: void cairo_svg_surface_set_document_unit (cairo_surface_t*, const char*) The string pointer must point at a valid svg unit type, such as "pt" or "em". NULL is the same as "" (which means "user" units). The function should do some basic sanity checks (maximum length, and only printing ASCII) and is a no-op if it fails. On Wed, Oct 11, 2017 at 1:45 PM, <<a href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a>> wrote: > <a href="show_bug.cgi?id=90166#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Add a way to specify units" href="show_bug.cgi?id=90166">bug 90166</a> from Adrian Johnson > > Please post API proposals to the mailing list for discussion. > > ________________________________ > You are receiving this mail because: > > You are watching the QA Contact of the bug.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>