<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Windows filenames should be in UTF-8 encoding" href="https://bugs.freedesktop.org/show_bug.cgi?id=103536#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Windows filenames should be in UTF-8 encoding" href="https://bugs.freedesktop.org/show_bug.cgi?id=103536">bug 103536</a> from <a class="email" href="mailto:psychon@znc.in" title="Uli Schlachter <psychon@znc.in>"> Uli Schlachter</a> <pre>Comment on <a href="attachment.cgi?id=135230" name="attach_135230" title="Patch to use UTF-8 filenames on Windows">attachment 135230</a> <a href="attachment.cgi?id=135230&action=edit" title="Patch to use UTF-8 filenames on Windows">[details]</a> <a href='page.cgi?id=splinter.html&bug=103536&attachment=135230'>[review]</a> Patch to use UTF-8 filenames on Windows Review of <a href="attachment.cgi?id=135230" name="attach_135230" title="Patch to use UTF-8 filenames on Windows">attachment 135230</a> <a href="attachment.cgi?id=135230&action=edit" title="Patch to use UTF-8 filenames on Windows">[details]</a> <a href='page.cgi?id=splinter.html&bug=103536&attachment=135230'>[review]</a>: ----------------------------------------------------------------- Any specific reason why not all calls to fopen() would get this new treatment? (Although I do agree that it would be a bit stupid for those cases with hardcoded ASCII file names, but still, consistency-wise it might be a good idea) $ git grep fopen | wc -l 60 $ git grep fopen src/ | wc -l 21 (Only src/ might make sense since stuff outside of libcairo does not get access to libcairo-internal symbols) I don't have much of an opinion here, I'm just asking. And API-doc-wise I want to mention the following callers of _cairo_output_stream_create_for_filename which in turn end up getting the file name from some public API: $ git grep _cairo_output_stream_create_for_filename src/cairo-output-stream-private.h:_cairo_output_stream_create_for_filename (const char *filename); src/cairo-output-stream.c:_cairo_output_stream_create_for_filename (const char *filename) src/cairo-pdf-surface.c: output = _cairo_output_stream_create_for_filename (filename); src/cairo-ps-surface.c: stream = _cairo_output_stream_create_for_filename (filename); src/cairo-script-surface.c: stream = _cairo_output_stream_create_for_filename (filename); src/cairo-svg-surface.c: stream = _cairo_output_stream_create_for_filename (filename); src/cairo-xml-surface.c: stream = _cairo_output_stream_create_for_filename (filename);</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>