<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:Tom.Schoonjans@me.com" title="Tom Schoonjans <Tom.Schoonjans@me.com>"> <span class="fn">Tom Schoonjans</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Windows filenames should be in UTF-8 encoding"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103536">bug 103536</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #135230 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Windows filenames should be in UTF-8 encoding"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103536#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Windows filenames should be in UTF-8 encoding"
href="https://bugs.freedesktop.org/show_bug.cgi?id=103536">bug 103536</a>
from <span class="vcard"><a class="email" href="mailto:Tom.Schoonjans@me.com" title="Tom Schoonjans <Tom.Schoonjans@me.com>"> <span class="fn">Tom Schoonjans</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=135258" name="attach_135258" title="Windows UTF-8 patch">attachment 135258</a> <a href="attachment.cgi?id=135258&action=edit" title="Windows UTF-8 patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=103536&attachment=135258'>[review]</a>
Windows UTF-8 patch
I think I addressed the comments with this new patch except the last suggestion
regarding using a for/while loop for the fopen mode. Though I agree that there
will be some overhead caused by using _cairo_utf8_to_utf16, I think that it's a
reasonable one, especially since these methods are unlikely to be called a lot
during the execution of a program.
I have also not gone ahead with replacing every occurrence in the source of
fopen to _cairo_fopen. Unless I missed one, the remaining ones are in DEBUG_*
sections only, and they are always passed ASCII string filenames, either
directly or indirectly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>