<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - cairo 1.14.12 hangs in read_png called from cairo_image_surface_create_from_png_stream on malformed png"
href="https://bugs.freedesktop.org/show_bug.cgi?id=104325#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - cairo 1.14.12 hangs in read_png called from cairo_image_surface_create_from_png_stream on malformed png"
href="https://bugs.freedesktop.org/show_bug.cgi?id=104325">bug 104325</a>
from <span class="vcard"><a class="email" href="mailto:orivej@gmx.fr" title="Orivej Desh <orivej@gmx.fr>"> <span class="fn">Orivej Desh</span></a>
</span></b>
<pre>If I qualify `png_setjmp` with `inline`, it warns (thanks to -Winline):
cairo-png.c: In function ‘png_setjmp’:
cairo-png.c:163:1: warning: function ‘png_setjmp’ can never be inlined because
it uses setjmp [-Winline]
png_setjmp (png_struct *png)
^~~~~~~~~~
cairo-png.c: In function ‘write_png’:
cairo-png.c:163:1: warning: inlining failed in call to ‘png_setjmp’: function
not inlinable [-Winline]
cairo-png.c:241:9: note: called from here
if (png_setjmp (png))
^~~~~~~~~~~~~~~~
cairo-png.c: In function ‘read_png’:
cairo-png.c:163:1: warning: inlining failed in call to ‘png_setjmp’: function
not inlinable [-Winline]
png_setjmp (png_struct *png)
^~~~~~~~~~
cairo-png.c:582:9: note: called from here
if (png_setjmp (png)) {
^~~~~~~~~~~~~~~~
We are building with gcc 6.4.0 (and glibc 2.26). Does your version of gcc
inline it?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>