[cairo-commit] cairo/test .valgrind-suppressions, NONE, 1.1 Makefile.am, 1.63, 1.64

Carl Worth commit at pdx.freedesktop.org
Mon Jul 18 14:35:56 PDT 2005


Committed by: cworth

Update of /cvs/cairo/cairo/test
In directory gabe:/tmp/cvs-serv7919/test

Modified Files:
	Makefile.am 
Added Files:
	.valgrind-suppressions 
Log Message:

        * test/.valgrind-suppressions: Add valgrind suppressions for
        libpng/libz use of uninitialized data. There are clearly bugs here
        that are not cairo's fault as zeroing the buffer before writing
        the png image actually causes more errors(\!). And, notably,
        setting all the data to random bytes usually makes the errors go
        away.

        * test/Makefile.am: Change the check-valgrind target to include
        the .valgrind-suppresions file and to tee output into
        valgrind.log.


--- NEW FILE: .valgrind-suppressions ---
{
   cairo's write_png triggers apparent bugs in libpng/libz
   Memcheck:Cond
   obj:/usr/lib/libz.so.1.2.2.2
   obj:/usr/lib/libz.so.1.2.2.2
   fun:deflate
   fun:png_write_finish_row
   fun:png_write_filtered_row
   fun:png_write_find_filter
   fun:png_write_row
   fun:png_write_image
   fun:write_png
 }
{
   cairo's write_png_argb32 triggers apparent bugs in libpng/libz
   Memcheck:Cond
   obj:/usr/lib/libz.so.1.2.2.2
   obj:/usr/lib/libz.so.1.2.2.2
   fun:deflate
   fun:png_write_finish_row
   fun:png_write_filtered_row
   fun:png_write_find_filter
   fun:png_write_row
   fun:png_write_image
   fun:write_png_argb32
 }

Index: Makefile.am
===================================================================
RCS file: /cvs/cairo/cairo/test/Makefile.am,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -d -r1.63 -r1.64
--- Makefile.am	15 Jul 2005 20:45:19 -0000	1.63
+++ Makefile.am	18 Jul 2005 21:35:54 -0000	1.64
@@ -190,4 +190,4 @@
 	pdf-clip.pdf
 
 check-valgrind:
-	TESTS_ENVIRONMENT="libtool --mode=execute valgrind --tool=memcheck --leak-check=yes --show-reachable=yes" $(MAKE) check
+	TESTS_ENVIRONMENT="libtool --mode=execute valgrind --tool=memcheck --suppressions=./.valgrind-suppressions --leak-check=yes --show-reachable=yes" $(MAKE) check 2>&1 | tee valgrind.log




More information about the cairo-commit mailing list