[cairo-commit] cairo-perl ChangeLog, 1.41, 1.42 MakeHelper.pm, 1.9, 1.10

Torsten Schoenfeld commit at pdx.freedesktop.org
Thu Nov 9 10:44:52 PST 2006


Committed by: tsch

Update of /cvs/cairo/cairo-perl
In directory kemper:/tmp/cvs-serv15310

Modified Files:
	ChangeLog MakeHelper.pm 
Log Message:
	* MakeHelper.pm, CairoSurface.t: When comparing enum values, look
	at length+1, not just length, bytes to discern string pairs like
	'color' and 'color-alpha'.  Duh!  Many thanks to Martijn van Beers
	for finding this bug.


Index: ChangeLog
===================================================================
RCS file: /cvs/cairo/cairo-perl/ChangeLog,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -d -r1.41 -r1.42
--- ChangeLog	24 Sep 2006 21:26:40 -0000	1.41
+++ ChangeLog	9 Nov 2006 18:44:49 -0000	1.42
@@ -1,3 +1,10 @@
+2006-11-09	tsch
+
+	* MakeHelper.pm, CairoSurface.t: When comparing enum values, look
+	at length+1, not just length, bytes to discern string pairs like
+	'color' and 'color-alpha'.  Duh!  Many thanks to Martijn van Beers
+	for finding this bug.
+
 2006-09-24	tsch
 
 	* Cairo.pm, NEWS: Stable release 1.01.

Index: MakeHelper.pm
===================================================================
RCS file: /cvs/cairo/cairo-perl/MakeHelper.pm,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -d -r1.9 -r1.10
--- MakeHelper.pm	20 Aug 2006 18:33:22 -0000	1.9
+++ MakeHelper.pm	9 Nov 2006 18:44:49 -0000	1.10
@@ -306,7 +306,10 @@
 
 		my $full = shift @enums;
 		my $name = canonicalize($full, $prefix);
-		my $len = length ($name);
+
+		# +1 so that strncmp also looks at the trailing \0, and discerns
+		# 'color' and 'color-alpha', for example.
+		my $len = length ($name) + 1;
 
 		my $str = <<"EOS";
 	if (strncmp (str, "$name", $len) == 0)



More information about the cairo-commit mailing list