[cairo-commit] 7 commits - boilerplate/.gitignore build/.gitignore src/.gitignore test/alpha-similar.c test/cairo-test.c test/device-offset-fractional-pdf-ref.png test/device-offset-fractional-ps-ref.png test/fill-alpha-pattern-pdf-argb32-ref.png test/fill-alpha-pattern-pdf-rgb24-ref.png test/gradient-constant-alpha-pdf-argb32-ref.png test/gradient-constant-alpha-pdf-rgb24-ref.png test/Makefile.am test/mask-transformed-similar-svg-ref.png test/operator-alpha.c test/operator.c test/README test/self-copy-overlap.c

Carl Worth cworth at kemper.freedesktop.org
Wed Sep 24 16:54:42 PDT 2008


 boilerplate/.gitignore                          |    2 ++
 build/.gitignore                                |    2 ++
 src/.gitignore                                  |    2 ++
 test/Makefile.am                                |    4 ++++
 test/README                                     |    2 ++
 test/alpha-similar.c                            |    3 ++-
 test/cairo-test.c                               |    2 +-
 test/device-offset-fractional-pdf-ref.png       |binary
 test/device-offset-fractional-ps-ref.png        |binary
 test/fill-alpha-pattern-pdf-argb32-ref.png      |binary
 test/fill-alpha-pattern-pdf-rgb24-ref.png       |binary
 test/gradient-constant-alpha-pdf-argb32-ref.png |binary
 test/gradient-constant-alpha-pdf-rgb24-ref.png  |binary
 test/mask-transformed-similar-svg-ref.png       |binary
 test/operator-alpha.c                           |    3 ++-
 test/operator.c                                 |    3 ++-
 test/self-copy-overlap.c                        |    3 ++-
 17 files changed, 21 insertions(+), 5 deletions(-)

New commits:
commit 62107b8015f0d359397a02d4f0fecf22647330b9
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 16:51:44 2008 -0700

    Mark several new tests added during 1.7 as XFAIL.
    
    The following tests were added during the 1.7 cycle to
    demonstrate bugs:
    
    	alpha-similar operator operator-alpha self-copy-overlap
    
    In all cases, the identical bug existed in the last major
    release, (1.6.4), so these are not new regressions, but merely
    bugs that we're now aware of. The correct way to handle bugs
    such as these is to mark them as expected failures (XFAIL).

diff --git a/test/Makefile.am b/test/Makefile.am
index 9685d37..c2fcdbf 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -777,6 +777,7 @@ $(REFERENCE_IMAGES)
 # everything from this list by fixing the bugs. (We don't necessarily
 # have to be that strict for "snapshots" though.)
 XFAIL_TESTS =					\
+alpha-similar$(EXEEXT)				\
 big-line$(EXEEXT)				\
 big-trap$(EXEEXT)				\
 extend-pad$(EXEEXT)				\
@@ -784,6 +785,9 @@ filter-nearest-offset$(EXEEXT)			\
 filter-bilinear-extents$(EXEEXT)		\
 large-source$(EXEEXT)				\
 long-lines$(EXEEXT)				\
+operator$(EXEEXT)				\
+operator-alpha$(EXEEXT)				\
+self-copy-overlap$(EXEEXT)			\
 self-intersecting$(EXEEXT)			\
 surface-pattern$(EXEEXT)			\
 surface-pattern-big-scale-down$(EXEEXT)		\
diff --git a/test/alpha-similar.c b/test/alpha-similar.c
index c1bddb8..526f4d0 100644
--- a/test/alpha-similar.c
+++ b/test/alpha-similar.c
@@ -29,7 +29,8 @@ static cairo_test_draw_function_t draw;
 
 static const cairo_test_t test = {
     "alpha-similar",
-    "Tests creation of similar alpha surfaces",
+    "Tests creation of similar alpha surfaces"
+    "\nApplication of a pure-alpha similar source is inconsistent across backends.",
     10, 10,
     draw
 };
diff --git a/test/operator-alpha.c b/test/operator-alpha.c
index 28dc7cb..128453c 100644
--- a/test/operator-alpha.c
+++ b/test/operator-alpha.c
@@ -33,7 +33,8 @@ static cairo_test_draw_function_t draw;
 
 static const cairo_test_t test = {
     "operator-alpha",
-    "Tests using set_operator() with an non-opaque source",
+    "Tests using set_operator() with an non-opaque source"
+    "\nCurrently failing on the PDF backend for an unknown reason.",
     (SIZE+PAD) * N_OPERATORS + PAD, SIZE + 2*PAD,
     draw
 };
diff --git a/test/operator.c b/test/operator.c
index bb269b2..2e4fbd9 100644
--- a/test/operator.c
+++ b/test/operator.c
@@ -33,7 +33,8 @@ static cairo_test_draw_function_t draw;
 
 static const cairo_test_t test = {
     "operator",
-    "Tests using set_operator()",
+    "Tests using set_operator()"
+    "\nCurrently failing on the PDF backend for an unknown reason.",
     (SIZE+PAD) * N_OPERATORS + PAD, SIZE + 2*PAD,
     draw
 };
diff --git a/test/self-copy-overlap.c b/test/self-copy-overlap.c
index 14a7878..5b1da90 100644
--- a/test/self-copy-overlap.c
+++ b/test/self-copy-overlap.c
@@ -32,7 +32,8 @@ static cairo_test_draw_function_t draw;
 /* This test is only interesting if the target has alpha */
 static const cairo_test_t test = {
     "self-copy-overlap",
-    "Tests painting to itself using itself as the source",
+    "Tests painting to itself using itself as the source"
+    "\nBackends treat this case inconsistently---vector backends are creating snapshots.",
     200, 200,
     draw
 };
commit c3750cf2187e6b590a93761cb28ad63d2806f81d
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 16:32:58 2008 -0700

    Remove the device-offset testing (-25 cases) for the release.
    
    The reasoning behind the -25 testing is that we want to ensure
    that cairo provides translation invariance. However, for
    many vector backends we use external rasterizers that don't
    necessarily provide that translation invariance.
    
    So this testing makes a bunch of failures appear that we don't
    really care about, (and we don't even have a mechanism to turn
    them off with custom reference images). For the release, I'm
    just turning this off.
    
    After the release, I plan to turn this back on, and then we could
    fix this by ensuring that the vector output itself is unaffected
    by a device offset, or by moving away from external rasterizers,
    (see Chris's micro-gs work to test PostScript with cairo-based
    rasterization).

diff --git a/test/cairo-test.c b/test/cairo-test.c
index e4f250c..08d3f5b 100644
--- a/test/cairo-test.c
+++ b/test/cairo-test.c
@@ -78,7 +78,7 @@ static const char *fail_face = "", *normal_face = "";
 #define CAIRO_TEST_REF_SUFFIX "-ref.png"
 #define CAIRO_TEST_DIFF_SUFFIX "-diff.png"
 
-#define NUM_DEVICE_OFFSETS 2
+#define NUM_DEVICE_OFFSETS 1
 
 static const char *vector_ignored_tests[] = {
     /* We can't match the results of tests that depend on
commit ea4d0bafb3d374e491f3956347c7510ea7b0d2b8
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 16:25:38 2008 -0700

    Add svg-specific reference image for mask-transformed-similar.
    
    The only difference in this case is whether there is blurring
    of the image around the edges. That's a rasterization issue
    that we don't care about, (we're testing that the correct
    transformation is applied).

diff --git a/test/mask-transformed-similar-svg-ref.png b/test/mask-transformed-similar-svg-ref.png
new file mode 100644
index 0000000..b4344cd
Binary files /dev/null and b/test/mask-transformed-similar-svg-ref.png differ
commit f939e46304093cad4d8bc3f545cc49a2888fd59f
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 16:21:57 2008 -0700

    Add pdf-specific reference images for gradient-constant-alpha.
    
    Like many other gradient tests, we're just capturing the buggy
    output of poppler here, (though this time I *did* verify with
    Adobe acroread that our PDF output seems to be correct).

diff --git a/test/README b/test/README
index 8648b30..ee57e9d 100644
--- a/test/README
+++ b/test/README
@@ -236,6 +236,7 @@ https://bugs.freedesktop.org/show_bug.cgi?id=12144
 --------------------------------------------------
 fill-alpha-pattern
 gradient-alpha
+gradient-constant-alpha
 linear-gradient
 trap-clip
 linear-gradient
diff --git a/test/gradient-constant-alpha-pdf-argb32-ref.png b/test/gradient-constant-alpha-pdf-argb32-ref.png
new file mode 100644
index 0000000..056fcb2
Binary files /dev/null and b/test/gradient-constant-alpha-pdf-argb32-ref.png differ
diff --git a/test/gradient-constant-alpha-pdf-rgb24-ref.png b/test/gradient-constant-alpha-pdf-rgb24-ref.png
new file mode 100644
index 0000000..60c0263
Binary files /dev/null and b/test/gradient-constant-alpha-pdf-rgb24-ref.png differ
commit 9335ad313fdc97c3c8d0e532319ac3f58c7f69fc
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 16:20:35 2008 -0700

    Ignore generated files.
    
    I know that I didn't create these Makefile.win32.features files,
    so I assume that they are the result of Behdad's build magic and
    that he just forgot to add them to .gitignore.

diff --git a/boilerplate/.gitignore b/boilerplate/.gitignore
index 3164656..b750c32 100644
--- a/boilerplate/.gitignore
+++ b/boilerplate/.gitignore
@@ -3,7 +3,9 @@ tags
 Makefile
 Makefile.in
 Makefile.am.config
+Makefile.am.features
 Makefile.win32.config
+Makefile.win32.features
 *.lo
 *.la
 *.exe
diff --git a/build/.gitignore b/build/.gitignore
index e11f30f..8b6b308 100644
--- a/build/.gitignore
+++ b/build/.gitignore
@@ -6,3 +6,5 @@ install-sh
 ltmain.sh
 missing
 mkinstalldirs
+Makefile.win32.features
+Makefile.win32.features-h
diff --git a/src/.gitignore b/src/.gitignore
index a1f26f2..73937b7 100644
--- a/src/.gitignore
+++ b/src/.gitignore
@@ -3,7 +3,9 @@
 Makefile
 Makefile.in
 Makefile.am.config
+Makefile.am.features
 Makefile.win32.config
+Makefile.win32.features
 *.gcda
 *.gcno
 *.la
commit 06594abc6b74a8260f92f7d9686f2ae5ce84e59f
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 16:03:12 2008 -0700

    Add pdf-specific reference images for fill-alpha-pattern.
    
    These capture the current poppler output, (rather than the
    ideal output). We're still waiting for poppler to start
    using cairo gradients before this test will run through
    cleanly. And even with these new reference images, there's
    still some translation variance, so the -25 tests still
    fail.

diff --git a/test/README b/test/README
index 984cbbe..8648b30 100644
--- a/test/README
+++ b/test/README
@@ -234,6 +234,7 @@ Here are the reported poppler bugs and the tests they affect:
 Poppler doesn't correctly handle gradients with transparency
 https://bugs.freedesktop.org/show_bug.cgi?id=12144
 --------------------------------------------------
+fill-alpha-pattern
 gradient-alpha
 linear-gradient
 trap-clip
diff --git a/test/fill-alpha-pattern-pdf-argb32-ref.png b/test/fill-alpha-pattern-pdf-argb32-ref.png
new file mode 100644
index 0000000..d786c86
Binary files /dev/null and b/test/fill-alpha-pattern-pdf-argb32-ref.png differ
diff --git a/test/fill-alpha-pattern-pdf-rgb24-ref.png b/test/fill-alpha-pattern-pdf-rgb24-ref.png
new file mode 100644
index 0000000..75e580f
Binary files /dev/null and b/test/fill-alpha-pattern-pdf-rgb24-ref.png differ
commit 64541a58aeafece3956bbe4cc4ec3bc2226d3d2a
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Sep 24 15:52:05 2008 -0700

    Add pdf- and ps-specific reference images for device-offset-fractional
    
    We don't care about the specifics of rasterization in the viewer
    here, (though it still might be worth being more careful about
    how we set /Interpolate---but that's not the point of this test).

diff --git a/test/device-offset-fractional-pdf-ref.png b/test/device-offset-fractional-pdf-ref.png
new file mode 100644
index 0000000..9ff2b8d
Binary files /dev/null and b/test/device-offset-fractional-pdf-ref.png differ
diff --git a/test/device-offset-fractional-ps-ref.png b/test/device-offset-fractional-ps-ref.png
new file mode 100644
index 0000000..72b144c
Binary files /dev/null and b/test/device-offset-fractional-ps-ref.png differ


More information about the cairo-commit mailing list