[cairo-commit] 2 commits - AUTHORS src/cairo-xcb-surface-render.c

Chris Wilson ickle at kemper.freedesktop.org
Thu Oct 14 07:09:43 PDT 2010

 AUTHORS                        |    1 +
 src/cairo-xcb-surface-render.c |    3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 6fecbb000d29dde153ce35ec08f663249f234b8e
Author: Uli Schlachter <psychon at znc.in>
Date:   Thu Oct 14 13:26:48 2010 +0200

    XCB: Remove an incorrect clipping optimizations
    It seems like the idea here was to optimize for the special case of a
    rectangular clip, where the region operation could be replace by
    direction operation on the draw extents. However, we cannot modify the
    geometry for all operations, and in particular the glyphs. So remove
    this from the common compositing path.
    This fixes partial-clip-text in the test suite.
    Signed-off-by: Uli Schlachter <psychon at znc.in>
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/cairo-xcb-surface-render.c b/src/cairo-xcb-surface-render.c
index 637a240..208d940 100644
--- a/src/cairo-xcb-surface-render.c
+++ b/src/cairo-xcb-surface-render.c
@@ -2407,9 +2407,6 @@ _clip_and_composite (cairo_xcb_surface_t	*dst,
 	    is_empty = ! _cairo_rectangle_intersect (&extents->bounded, &rect);
 	    if (unlikely (is_empty && extents->is_bounded))
-	    if (cairo_region_num_rectangles (clip_region) == 1)
-		clip_region = NULL;
commit 408033b4641ba66de0cb60df1c89e437d7422040
Author: Uli Schlachter <psychon at znc.in>
Date:   Wed Oct 13 20:15:16 2010 +0200

    Add myself to AUTHORS
    I was looking around for changes that I could do. This what I came up with.
    Seems boring, but nothing better came up this time.
    Signed-off-by: Uli Schlachter <psychon at znc.in>
    [ickle: Apologies for not doing it on your behalf.]
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/AUTHORS b/AUTHORS
index 45509f8..3c26f75 100644
@@ -82,6 +82,7 @@ Calum Robinson <calumr at mac.com> Quartz backend
 Pavel Roskin <proski at gnu.org> Several cleanups to eliminate warnings
 Tim Rowley <tim.rowley at gmail.com> Quartz/ATSUI fixes, X server workarounds, win32 glyph path support, test case to expose gradient regression
 Soeren Sandmann <sandmann at daimi.au.dk> Lots of MMX love for pixman compositing
+Uli Schlachter <psychon at znc.in> Some more XCB fixes
 Torsten Schönfeld <kaffeetisch at gmx.de> Build fixes
 Jamey Sharp <jamey at minilop.net> Surface/font backend virtualization, XCB backend
 Jason Dorje Short <jdorje at users.sf.net> Build fixes and bug fixes

More information about the cairo-commit mailing list