[cairo-commit] src/cairo-xlib-surface-shm.c

Chris Wilson ickle at kemper.freedesktop.org
Tue Dec 18 12:30:08 PST 2012


 src/cairo-xlib-surface-shm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5d21c9e224617110678a5b854a6a41049a02fca2
Author: Adam Jackson <ajax at redhat.com>
Date:   Tue Dec 18 13:33:13 2012 -0500

    xlib/shm: Fix memory leak
    
    Despite subclassing image surfaces, we never called down to the image
    surface destructor, so we leaked a pixman_image_t every time.
    
    Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=882976
    Signed-off-by: Adam Jackson <ajax at redhat.com>

diff --git a/src/cairo-xlib-surface-shm.c b/src/cairo-xlib-surface-shm.c
index b03dd83..684d7e8 100644
--- a/src/cairo-xlib-surface-shm.c
+++ b/src/cairo-xlib-surface-shm.c
@@ -679,7 +679,7 @@ _cairo_xlib_shm_surface_finish (void *abstract_surface)
     cairo_list_del (&shm->link);
 
     cairo_device_release (&display->base);
-    return CAIRO_STATUS_SUCCESS;
+    return _cairo_image_surface_finish (abstract_surface);
 }
 
 static const cairo_surface_backend_t cairo_xlib_shm_surface_backend = {


More information about the cairo-commit mailing list