[cairo-commit] 2 commits - configure.ac util/cairo-sphinx

[Bryce Harrington]

 configure.ac               |    2 +-
 util/cairo-sphinx/sphinx.c |    8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

New commits:
commit fbb0a260b707cb5f02a14cc368c6f2f0d63564c3
Author: Marc-André Lureau <marcandre.lureau at gmail.com>
Date:   Tue Apr 2 21:00:20 2013 +0200

    build-sys: do not try to build util/sphinx on Windows
    
    glib and dlfcn exist on windows, but sphinx code uses a lot of
    Unix-only API
    
    Fixes the following build error on mingw-fedora
    
      CC     cairo-boilerplate-system.lo
    ../../../util/cairo-sphinx/sphinx.c:8:22: fatal error: sys/mman.h: No such file or directory
    compilation terminated.
    
    Fixes:  https://bugs.freedesktop.org/show_bug.cgi?id=63043
    Reviewed-by: Bryce Harrington <b.harrington at samsung.com>

diff --git a/configure.ac b/configure.ac
index 4e28adf..2ce1959 100644
--- a/configure.ac
+++ b/configure.ac
@@ -805,7 +805,7 @@ CAIRO_ENABLE(symbol_lookup, symbol-lookup, auto, [
 PKG_CHECK_MODULES(glib, glib-2.0, have_glib=yes, have_glib=no)
 AC_SUBST(glib_CFLAGS)
 AC_SUBST(glib_LIBS)
-AM_CONDITIONAL(BUILD_SPHINX, test "x$have_glib" = "xyes")
+AM_CONDITIONAL(BUILD_SPHINX, test "x$have_glib" = "xyes" -a "x$have_windows" = "xno")
 
 save_LIBS="$LIBS"
 AC_CHECK_LIB(rt, shm_open, shm_LIBS="-lrt")
commit 42320793aa1b3e5a0b74e94a0aadf5d2b9ae5ce2
Author: Bryce Harrington <bryce at osg.samsung.com>
Date:   Wed Sep 24 11:37:58 2014 -0700

    sphinx: Add ickle's explanation of what sphinx does

diff --git a/util/cairo-sphinx/sphinx.c b/util/cairo-sphinx/sphinx.c
index 7bc1c50..3a6c04c 100644
--- a/util/cairo-sphinx/sphinx.c
+++ b/util/cairo-sphinx/sphinx.c
@@ -1,3 +1,11 @@
+/*
+ * The intention for sphinx is for detection of rendering errors inside
+ * applications by simultaneously rendering on to the target device and on
+ * an image surface and comparing the two. If it found a discrepancy, it
+ * would then dump the trace that reproduces the error. (Then apply
+ * delta-debugging to reduce that down to a minimal trace.)
+ */
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif