[Cairo] X server CPU Load problem

[Carl Worth]

On Aug 27, Soorya Kuloor wrote:
 > I am attaching a test program that makes the X server consume approx.
 > 100% CPU after a while. The program basically redraws the screen every
 > 200ms with alternate colors, basically giving an appearance of blinking
 > figures.

Soorya,

I've just committed a fix to Cairo CVS that should correct this
problem.

You mentioned to me recently that the X server memory was
increasing. I took a look with the X-Resource extension[*] and it was
plain to see that the client was leaking pixmaps into the server.

Now that I knew what to look for it was easy to find the problem in
Cairo. Rather embarrassing really:

	-/* XXX: huh? This should be fine since we already created a picture
	-       from the pixmap, right?? (Somehow, it seems to be causing some
	-       breakage).
	        XFreePixmap (surface->dpy, pix);
	-*/

I think at one point the pixmap was mistakenly being freed multiple
times. But I must have fixed that bug in both spots. ;-)

Ah well. Hopefully it should behave much more nicely now. I no longer
see any increase in server resources when running the example.

-Carl

[*] http://mail.gnome.org/archives/gnome-hackers-readonly/2002-March/msg00127.html