[cairo] Hash rewrite #2: cairo_toy_font_face_hash_table

Keith Packard keithp at keithp.com
Wed Aug 10 18:01:41 PDT 2005


On Mon, 2005-08-08 at 07:33 -0700, Carl Worth wrote:

> Unlike the previous patch, I did not put the new code in an awkward
> order just to make the patch easier to read. Hopefully it will still
> be quite clear. This is a fairly simple change that follows the same
> model as the previous patch.

I suggest changing the family type in the cache to const and using a
cast to (char *) on the call to free instead of on the assignment; that
should bring the necessary comment next to the cast and assert that no
other non-const usages are present in the code.

Other than that, the code looks fine to me.

-keith

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050810/6836161e/attachment.pgp


More information about the cairo mailing list