[cairo] Re: [cairo-commit] cairo/pixman/src icrect.c,1.15,1.16

Keith Packard keithp at keithp.com
Wed Aug 10 22:32:15 PDT 2005


On Wed, 2005-08-10 at 22:03 -0700, Billy Biggs wrote:
> Committed by: vektor
> 
> Update of /cvs/cairo/cairo/pixman/src
> In directory gabe:/tmp/cvs-serv21675/src
> 
> Modified Files:
> 	icrect.c 
> Log Message:
> 	* src/icrect.c: (pixman_fill_rect_1bpp), (pixman_color_rects):
> 	Add support for filling 1bpp images (used to clear A1 masks).

The fb code has depth-independent filling code which might be more
appropriate here. The applied patch is also broken in that it is byte
addressed in X and pixel addressed in width, and rounds the width up to
a multiple of 8.

Is there some reason all of these functions aren't just using the
existing code?

-keith

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050810/a2556c7b/attachment.pgp


More information about the cairo mailing list