[cairo] Fixing cairo_show_text to advance the current point

[Owen Taylor]

On Tue, 2005-08-23 at 16:46 -0700, Carl Worth wrote:
> On Tue, 23 Aug 2005 19:39:13 -0400, Owen Taylor wrote:
> > > Any objections to this going in?
> > 
> > Hmm:
> > 
> >  - The Pango functions that show text are not going to be changed
> >    at this point. (show_layout, show_layout_line, 
> >    show_glyph_string)
> 
> I don't see that as a big source of confusion, do you? (Though, it is
> unfortunate I waited so long to get around to changing this, as
> perhaps the pango APIs would have adopted a similar convention.)

Well, if it was three months ago, I'd be arguing that both the
Cairo and Pango APIs should ignore the current point and take
coordinates as input....

I think some people will use both, and the Pango APIs *are* modelled
after the Cairo APIs but the fact that show_layout() shows an entire
paragraph should reduce the similarity enough that people are
unlikely to get into too much trouble. 

> >  - Your patch doesn't change show_glyphs(), and I tend to agree
> >    with that.
> 
> Yes, that was quite intentional.
> 
> > So, the question is - is the gain in convenience for the toy API
> > worth the possible confusion and the need to document the 
> > inconsistency?
> 
> Where would we be documenting inconsistency? In pango vs. cairo? I see
> the pango APIs as quite distinct from cairo_show_text. Would you
> expect users to mix these calls?

I meant with respect to show_glyphs(), mostly. I think the difference
there does need to be mentioned.

Regards,
						Owen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050823/229e83dd/attachment-0001.pgp