[cairo] win32 port leaks

Owen Taylor otaylor at redhat.com
Sun Feb 20 18:15:02 PST 2005


Oleg Smolsky wrote:
> Hello Owen,
> 
> Owen Taylor wrote on Monday, 21 February 2005:
> 
>>>as Hans Breuer mentioned this in
>>>http://lists.freedesktop.org/archives/cairo/2005-February/003014.html
>>>
>>>The current CVS version of cairo leaks GDI objects (bitmaps and
>>>DCs) on win32. Below, are the descriptions of two bugs:
> 
> OT> I'm confused ... is there anything different here than in Hans's
> OT> message? (I want to get his patch in the next day or two)
> Probably quite similar, at least as far a the first bug goes. I was
> unable to apply the original patch - the CVS version must've
> evolved...
> 
> Anyway, my version is attached, so you can do a diff.

Not easily ... you've changed the whitespace. Reindenting makes
it very hard to find out what changed. While I can do a whitespace
insensitive diff, applying the patch from that would result in
a mix of different whitespace amounts.

Regards,
							Owen



More information about the cairo mailing list