[cairo] patch for crash in cairo-ft-font.c

Owen Taylor otaylor at redhat.com
Mon May 9 13:31:02 PDT 2005

On Fri, 2005-05-06 at 09:48 +1200, Robert O'Callahan wrote:
> Yesterday I encountered a crash in  _cairo_ft_unscaled_font_create_glyph
> --- in "glyphslot = unscaled->face->glyph", unscaled->face is null. The
> attached patch fixes it and appears logical although I'll be the first
> to admit I haven't really understood this code.

Ah. I see, if you are neither locking the face yourself (as Pango
does in many cases) or letting Cairo convert text=>glyphs (which
locks the face), you will end up there with unscaled->face == NULL
in some cases.

I'll apply something like this (should be face->glyph, not 
unscaled->face->glyph, but it's basically right)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050509/848bb3d7/attachment.pgp

More information about the cairo mailing list