[cairo] libsvg memory mis-management in patterns

Keith Packard keithp at keithp.com
Wed May 11 22:03:32 PDT 2005

svg_pattern_init calls 

	_svg_element_create (&pattern->group_element...)

svg_pattern_init_copy does not, instead it calls only

	_svg_element_init_copy (pattern->group_element, other->group_element)

I think this is wrong -- it will use the same group_element for both

svg_pattern_deinit calls only 

	_svg_element_deinit (pattern->group_element)

I think this is wrong -- it should call

	_svg_element_destroy (pattern->group_element)

to both clean up the group_element and free the memory allocated
in svg_pattern_init above.

Anyone have different opinions?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050511/01860078/attachment.pgp

More information about the cairo mailing list