[cairo] clipping bug

Radek Doulík rodo at novell.com
Mon Sep 12 10:14:32 PDT 2005

On Wed, 2005-08-31 at 09:08 -0700, Carl Worth wrote:
> On Thu, 25 Aug 2005 15:22:01 +0200, Radek Doulík wrote:
> > I prepared a fix which stops compositing even earlier. That way it will
> > not hide other bugs, where compositing with zero width or height. It is
> > included in the new patch.
> There's a style change I'd like to see for this bug fix. What I would
> like to see is:
> 	if (nothing_to_do)
> 	    return; /* or GOTO perhaps */
> rather than:
> 	if (! nothing_to_do) {
> 	    /* Big existing block now indented more. */
> 	}
> I've got some notes on this general style point in cairo/CODING_STYLE.

I am attaching an updated patch (sorry for a delay). It avoids adding
one more level of indentation. It also expects cairo_surface_destroy to
work when called with NULL the same way as g_free does, which I hope is
OK (it is handled in the code, it is not mentioned in the documentation

Next, it also replaces cairo_test_expect_failure with cairo_test call in
clip-all.c as it is not expected to fail anymore.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: clip-all.patch
Type: text/x-patch
Size: 2721 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20050912/b0d32ef0/clip-all.bin

More information about the cairo mailing list