[cairo] sincos patch final(?) patch

Behdad Esfahbod behdad at cs.toronto.edu
Mon Sep 12 22:08:03 PDT 2005


On Tue, 13 Sep 2005, Albert Chin wrote:

> On Mon, Sep 12, 2005 at 11:50:26PM -0400, Behdad Esfahbod wrote:
> > Index: src/cairoint.h
> > ===================================================================
> > RCS file: /cvs/cairo/cairo/src/cairoint.h,v
> > retrieving revision 1.210
> > diff -u -p -r1.210 cairoint.h
> > --- src/cairoint.h	7 Sep 2005 23:57:59 -0000	1.210
> > +++ src/cairoint.h	13 Sep 2005 03:48:44 -0000
> > @@ -66,6 +66,19 @@
> >  #include "cairo-debug.h"
> >  #include <pixman.h>
> >
> > +
> > +#define _GNU_SOURCE               /* Needed for sincos() in math.h */
>
> Might it be a problem to define this unconditionally? It's not hard to
> devise an autoconf test to determine if _GNU_SOURCE is needed to
> expose sincos().

Not really, it's fairly harmless...  In fact it does more good
than it harms, since some bogus X headers define things like
XOPEN_SOURCE that make glibc hide some of its otherwise standard
features...

--behdad
http://behdad.org/


More information about the cairo mailing list