[cairo] [PATCH] Fix for 64k string limit in truetype fonts in
krh at bitplanet.net
Wed Aug 2 12:19:36 PDT 2006
On 8/2/06, Carl Worth <cworth at redhat.com> wrote:
> On Sat, 29 Jul 2006 01:00:20 +0930, Adrian Johnson wrote:
> > This patch fixes the problem where the postscript output
> > does not print when the size of the embedded truetype font
> > exceeds 64k.
> Hi Adrian,
> Thanks for the patch! It's nice to see the "this code is broken"
> comments disappearing from the implementation. Kristian, could you
> review this patch please?
Not much to say, the patch looks good and even adds trailing 00's to
the hex string as required for compatibility (I miss that in the
current version). We need to free subset->string_offsets in
_cairo_truetype_subset_fini and there's a stray
+ unsigned long string_offset_length;
in _cairo_truetype_subset_init which I moved to the top and used for
the string_offsets length calculation so the lines wrap a little
better. I've committed the patch with these changes.
> And I wanted to also thank you, Adrian, for the good work on the font
> backends to allow font-backend-independent subsetting of truetype
> fonts [*]. Just let me know when we start not pushing your commits in
> quickly enough and you'd like to start doing that yourself.
Indeed, this is good work and we should pick that up as soon as it's
ready. Carl, maybe you could set up a git user repo for Adrian to
publish his work to? It's easier than posting patches in bugzilla.
More information about the cairo