[cairo] Re: [cairo-commit] configure.in
behdad at behdad.org
Fri Dec 1 15:08:08 PST 2006
On Fri, 2006-12-01 at 15:02 -0800, Daniel Amelang wrote:
> > Please set disable_some_floating_point=no before AC_ARG_ENABLE. Avoids
> > some Russian Rolette effects ;).
> Doh, I knew something would go wrong on my first day of pushing :(
That's fine. I could have fixed it, but thought mentioning it will help
if in the future.
> In my defense, though, I did submit this for review to the list a
> couple days ago, so I guess you should have complained then :)
No complaint. Friendly reminder :).
> So, looking at similar code in configure.in, it looks like the Right
> Thing To Do is set the variable to 'no' in the third argument of
> AC_ARG_ENABLE. Most variables aren't set before AC_ARG_ENABLE like
> you suggest. Any preference/reason?
Right. Third arg is fine. In situations other than AC_ARG_* we
typically set it before starting the test.
> BTW, I'm on the cairo-commit list now.
"Those who would give up Essential Liberty to purchase a little
Temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin, 1759
More information about the cairo