[cairo] [PATCH] Performance patch for bo intersections
cworth at cworth.org
Mon Dec 11 18:18:41 PST 2006
On Tue, 12 Dec 2006 01:46:35 +0000, Baz wrote:
> as requested Carl, this passes make test for me.
> PS I'm still new to git. Created this with cg-diff; is this what you
cg-diff should be just fine, but this on the other hand:
> Content-Type: application/octet-stream; name=perf.patch
> Content-Transfer-Encoding: base64
> X-Attachment-Id: f_evln7qw5
> Content-Disposition: attachment; filename="perf.patch"
is not fine.
We need plain-text patches so we can reply and comment on them.
Please re-send without binary encoding of the patch, (if that means
making the patch an inline part of the message rather than an
attachment, then that can work too).
Oh, but there is one thing better than cg-diff. That would be to
actually make a commit first, (with a commit message), and then send a
patch generated from that. That will give us proper attribution (that
you authored the patch) and an accurate commit message written by the
author rather than the committer. So, with cogito that's these two
And with core git that would be:
git commit -a
git format-patch origin..master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20061211/dbcd44b8/attachment.pgp
More information about the cairo