[cairo] Re: device offsets handling and push/pop group support patches

Vladimir Vukicevic vladimirv at gmail.com
Wed Jan 25 12:47:55 PST 2006

I mentioned this patch on IRC a little while ago, attaching here as
well.  This is just the device offset test bits.  It'll run each test
twice now, once with no device offset and once with 25.  Some of the
argument explosion is mitigated also, though some can't be helped
(three separate stride args).

Let me know if this is ok to commit.

- Vlad

On 1/4/06, Carl Worth <cworth at cworth.org> wrote:
> On Fri, 23 Dec 2005 20:01:33 +0100, Vladimir Vukicevic wrote:
> > Updated patches; device x/y scale are now handled, so the PS surface
> > is happy now with non-72dpi resolutions.  However, the PS surface is
> > still not happy with device offsets -- I haven't yet tried to follow
> > through the meta surface/image surface/etc., and may need some help in
> > doing so.  push_group/pop_group are thus broken for ps surfaces.
> I'll be taking a look at the effects of the device-offset patch on the
> meta-surface and friends.
> Let's start by getting the testing code committed to CVS first. That
> is quite separable from the rest, and I'm always happy to see testing
> in place before a bunch of code that shakes things up.
> First, I'd like to see the device-offset testing happening without
> anyone having to remember to set an environment variable and re-run
> the test suite. How about we just run every test twice, once with a
> device offset and once without?
> Second, this patch adds a bit of an argument explosion through the
> buffer_diff functions. Let's drop the new offsets from those, and
> handle all of this with just the extra stride parameters.
> Thanks.
> -Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: device-offset-test.patch
Type: text/x-patch
Size: 34474 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20060125/993c5de4/device-offset-test-0001.bin

More information about the cairo mailing list