[cairo] [PATCH] OS/2 backend support files

Peter Weilbacher (Mozilla) mozilla at Weilbacher.org
Mon Jul 31 15:37:37 PDT 2006


On Mon, 31 Jul 2006 16:11:38 -0400, Behdad Esfahbod wrote:

>This ain't gonna work.  You should at least make sure you know where
>this is being used and update that too!  The png_CFLAGS/etc are used by
>the CAIRO_BACKEND_ENABLE macro and they should match the first parameter
>passed to that macros.  So, if you want to change png_CFLAGS to
>PNG_CFLAGS, you need to update other places too.  And currently that
>macro doesn't support that, as the first argument has got to be in lower
>case.  So, to fix your problem, you need to add yet another argument to
>that macro and update all the rest of configure.in to use that.

Huh, seems like my testing procedure was broken, everything seemed to work. 
And I didn't look at the code of the macro, just at its documentation 
above.[1]

Sounds like you are not in favor of making such a big change, and actually I 
am too busy with too many other things to do that. So let's just forget about 
it.

   Peter.

[1] In the documentation of the CAIRO_BACKEND_ENABLE in configure.in (line 100 
and following) something is mismatched between there parameters and there 
explanation in the following lines.




More information about the cairo mailing list