[cairo] [PATCH] PS/PDF improve efficiency of text output

Carl Worth cworth at cworth.org
Mon Oct 2 21:34:31 PDT 2006

On Mon, 2 Oct 2006 16:47:34 -0700, Bryce Harrington wrote:
> When you post patches, could you also prefix them with the name and
> version of cairo to patch?  E.g.,
>   cairo-1.2.4-my-patchset.diff
> This'll help in determining what released version of cairo the patch
> should be applied to.

Patches should almost never be generated against a released version of
cairo, but instead against the very latest code that exists at the tip
of the "master" branch of cairo's central tree as available through
git. (The only exception would be if someone were patching a stable
branch in preparation for a maintenance release.)

And similarly, crucible shouldn't be testing "stable release + some
patch" but also "current master + some patch".

Finally, the tip of the master branch currently has a version of
1.2.5, (should be changing to 1.3.x soon), so using "1.2.4" for
patches against master would be really confusing. Please don't do

Bryce, if your system really needs some naming scheme to find some
base version I'm sure we can come up with something that would also be
reasonable for the patch submission guidelines I'm suggesting
here. For example, one thing that would be reasonable would be to use
an abbreviated sha1 of a base commit of interest, (I'm actually
surprised that git-diff and git-format-patch don't seem to use

But really, if a patch cannot be applied to cairo's master branch,
then the patch author really needs to update it, so it wouldn't be bad
at all if crucible failed in that case to let the patch author know
about the problem.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20061002/24a8b006/attachment.pgp

More information about the cairo mailing list