[cairo] Re: [cairo-commit] src/cairo-xcb-surface.c

Owen Taylor otaylor at redhat.com
Tue Oct 17 11:38:31 PDT 2006

On Tue, 2006-10-17 at 14:28 -0400, Behdad Esfahbod wrote:
> On Tue, 2006-10-17 at 11:11 -0400, Ian Osgood wrote:
> > 
> > +#include "cairo-clip-private.h"        /* XXX */ 
> When committing to cairo please avoid comments like this :).  If there
> is something you want to remind the reader here, you really should also
> write what it is.  You are not the only one reading the code later.  In
> fact, in the long run, you definitely are not the one who needs to be
> able to understand the comment!

And in addition, when *you* read this again, you will have no idea
what you meant :-)
						- Owen

More information about the cairo mailing list