[cairo] Re: [cairo-commit] src/cairo-png.c

Chris Wilson chris at chris-wilson.co.uk
Mon Apr 23 12:45:35 PDT 2007


Behdad Esfahbod (behdad at behdad.org) said: 
> On Mon, 2007-04-23 at 08:10 -0400, Chris Wilson wrote:
> > 
> > +    longjmp (png_save_ptr->jmpbuf, CAIRO_STATUS_NO_MEMORY); 
> 
> Hi Chris.  Any way we can return better/multiple status here?
> NO_MEMORY for a broken png file is misleading at best.  Weirdly enough
> we don't have a INVALID_DATA or something similar.  We probably should
> add one.

I had anticipated that request, hence the usage ;-) I'm not sure at this
moment what facilities libpng provides that we could use to translate to
more correct cairo_status_t values but it should be easy enough to plug
something in.

Suggestions anybody?
--
Chris Wilson


More information about the cairo mailing list