[cairo] Re: Add missing include of libgen.h for basename (Was Re: [cairo-commit] 4 commits - perf/cairo-perf-diff-files.c pixman/src src/Makefile.am)

[Behdad Esfahbod]

On Sat, 2007-04-28 at 10:46 -0400, Carl Worth wrote:
> diff-tree 422798db1d73c1a8ecc5877133b0325023f38e61 (from
> d89d8e6b45b7c13b77aa7c2f1c480f58429b08af)
> Author: Carl Worth <cworth at cworth.org>
> Date:   Sat Apr 28 07:46:15 2007 -0700
> 
>     cairo-perf-diff-files: Add missing include of libgen.h for
> basename
> 
> diff --git a/perf/cairo-perf-diff-files.c
> b/perf/cairo-perf-diff-files.c
> index adbc63b..108940d 100644
> --- a/perf/cairo-perf-diff-files.c
> +++ b/perf/cairo-perf-diff-files.c
> @@ -38,6 +38,7 @@
>  #include <ctype.h>
>  #include <math.h>
>  #include <assert.h>
> +#include <libgen.h>

Probably worth a configure check for libgen.h as it's a POSIX header,
not a C one.  Also, the basename(3) manual says the POSIX version of
baseline may modify its input string.  Is the code using it prepared for
that?

Cheers,

-- 
behdad
http://behdad.org/

"Those who would give up Essential Liberty to purchase a little
 Temporary Safety, deserve neither Liberty nor Safety."
        -- Benjamin Franklin, 1759