[cairo] Re: Add missing include of libgen.h for basename
(Was Re: [cairo-commit] 4 commits -
perf/cairo-perf-diff-files.c pixman/src src/Makefile.am)
behdad at behdad.org
Mon Apr 30 16:12:29 PDT 2007
On Mon, 2007-04-30 at 14:48 -0700, Carl Worth wrote:
> On Mon, 30 Apr 2007 17:27:09 -0400, Behdad Esfahbod wrote:
> > On Mon, 2007-04-30 at 14:12 -0700, Carl Worth wrote:
> > >
> > > 1. Don't compile anything in boilerplate, test, or perf when the user
> > > just says "make".
> > I thought it's already the case. I made it build boilerplate on "make"
> > a few snapshots ago but then the quartz/xlib conflict happened and I
> > removed it again.
> It doesn't seem like it based on feedback from the latest snapshot:
> On Sat, 28 Apr 2007 10:25:32 +0200, Richard Hult wrote:
> It doesn't build for me on OS X because of the following:
> cairo-perf-diff-files.c: In function 'cairo_perf_report_load':
> cairo-perf-diff-files.c:395: error: implicit declaration of function 'basename'
> So people are reporting build breakage in cairo-perf-diff-files.c, but
> really we shouldn't even be descending into perf, right?
It's fine to descend into it, for things like "make test" or "make
perf". Just made it not build anything in "make all".
"Those who would give up Essential Liberty to purchase a little
Temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin, 1759
More information about the cairo