[cairo] Fill+stroke optimisation for the SVG backend
cworth at cworth.org
Thu Aug 23 08:32:45 PDT 2007
On Wed, 01 Aug 2007 23:37:31 +0200, Emmanuel Pacaud wrote:
> > PDF has a fill then stroke operator so this optimisation can be done. In
> > PS the path can be reused by wrapping the fill in a gsave/grestore.
> Ok, good to know. So one question remains: does my implementation looks
> ok for inclusion in cairo ?
The implementation looks just fine to me. Well done!
I'd feel fine with you pushing this out right away. Here are a few
little things you might consider:
1. It might be nice to rebase the branch onto the latest master,
(you've already got one merge at the tip of your branch, and you
might end up with a second one soon).
2. While rebasing you might take advantage of the chance to fix a
couple of misspelling in the current f84de37e9 commit, (though I
like "meat surface" quite a lot for some reason). :-)
3. A nice addition would be a test case that exercises this new code
path. But that needn't hold this work out.
And afterward, it would be nice for anyone motivated to implement PDF
or PS fill_stroke functions. They should be _extremely_ simple now
that Emmanuel has done this ground work.
Thanks again! And sorry about the slow review process, (but thanks for
reminding me to take a look).
Please, anyone, feel free to ping me if you've got outstanding cairo
work that you feel is blocking on review from a cairo maintainer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20070823/eaf24d64/attachment.pgp
More information about the cairo