[cairo] SVG radial gradient fix

Emmanuel Pacaud emmanuel.pacaud at lapp.in2p3.fr
Tue Mar 6 12:04:09 PST 2007


On mar, 2007-03-06 at 06:59 +0100, Emmanuel Pacaud wrote:
> On lun, 2007-03-05 at 16:06 -0800, Carl Worth wrote:
> > On Mon, 05 Mar 2007 21:52:24 +0100, Emmanuel Pacaud wrote:
> > > It looks like the patch below fixes the radial gradient test for SVG
> > > surface. The output is not exactly the same as the reference one, but it
> > > should be good enough. I've attached the resulting svg file and what
> > > librsvg renders (batik rendering looks the same).
> > 
> > Thanks very much for this fix! I've just pushed it out now, so it
> > will be great to have this in place for cairo 1.4.
> 
> > As is, I think that EXTEND_NONE, EXTEND_PAD, and EXTEND_REPEAT are
> > handled perfectly fine. However, I think the handling of
> > CAIRO_EXTEND_REFLECT is still slightly off and could be improved.
> > 
> > But regardless, it's definitely much, much better than it was before.
> 
> I'm sorry, but it's a dumb patch that only fixes the radial test (where
> r1/r0 is approximatively an integer). Expect a real patch in a couple of
> hours.

A couple of couple of couple hours later, here's the announced patch. It
should also prevent a crash when r0 == r1 and make radial gradients work
when r0 > r1.

	Emmanuel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cairo-radial-gradient-03.patch
Type: text/x-patch
Size: 14342 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20070306/927b0f36/cairo-radial-gradient-03.bin


More information about the cairo mailing list