[cairo] Returning cached erroneous patterns

[Chris Wilson]

Behdad's already fixed the primary case where we created a pattern
and explicity put it into an error state. However, it also possible for
a user to set an error status on a solid pattern, for example by using
it as an argument where a gradient was expected. That has some rather
unfortunate side-effects on a widely shared pattern...

This patch endeavours not to return a cached pattern that is in an error
state. Along the way, it also tidies up a return without dropping the
pattern cache mutex.
--
Chris Wilson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Do-not-return-any-cached-pattern-that-is-in-an-error.patch
Type: text/x-diff
Size: 2450 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/cairo/attachments/20070322/5f3c572c/0006-Do-not-return-any-cached-pattern-that-is-in-an-error-0001.bin