[cairo] Can anyone help me to review the patch?

Dan Amelang daniel.amelang at gmail.com
Sun Nov 25 22:50:29 PST 2007

On Nov 25, 2007 10:12 PM, brian.lu <Brian.Lu at sun.com> wrote:
> experts,
> I've posted a patch at https://bugs.freedesktop.org/show_bug.cgi?id=11529
> Can anyone review the patch for me?
> Is there any formal process that I should follow to get the patch
> checked into the trunk code?

First, you should address the (quite valid) concerns Ginn Chen brought
up about your patch (especially wrt indentation). In addition, I
suggest you take out any non-mediaLib improvements and put them in a
separate patch.

For example, this part of the patch doesn't have anything to do with mediaLib:

> --- pixman/pixman/pixman-compose.c.old	2007-11-08 14:14:10.870989000 +0800
> +++ pixman/pixman/pixman-compose.c	2007-11-09 18:56:09.696762000 +0800
> (snip)
> @@ -1803,11 +1807,16 @@
> (the next 15 lines or so)

Make some noise once you've addressed those issues, and we'll go from there.


More information about the cairo mailing list