[cairo] Use _cairo_rectangle_intersect in more places for intersection checking
bjourne at gmail.com
Thu Oct 25 05:06:22 PDT 2007
On 10/23/07, Jeff Muizelaar <jeff at infidigm.net> wrote:
> On Mon, Oct 22, 2007 at 10:52:46PM +0000, BJörn Lindqvist wrote:
> > Which is important for the second patch that modifies all
> > _cairo_*_get_image() functions so that they now use the
> > _cairo_rectangle_intersect() function for doing intersection checking
> > instead of spelling it out themselves.
> > The benefit is that quite a few lines of code are removed. I also
> > added some docstrings to some touched functions because I found it
> > hard to tell what those functions were doing.
> Nit: Both patches add some inconsistent indentation.
Actually it just seems like that because I have indented using spaces
instead of tabs. In the patch, if the line starts with a '+' and then
a tab, then the tab will jump to column 8 which is only 7 spaces,
which is why some lines look inconsistent. Tabs are pure evil.
More information about the cairo