[PATCH] Don't copy unused bits to an alpha channel

Carl Worth cworth at cworth.org
Tue Sep 4 17:24:04 PDT 2007


This bug was identified by cairo's rgb24-ignore-alpha test which
blends RGB24 over ARGB32 and notices that "alpha" values are
making it from the source to the destination.
---
 pixman/pixman-pict.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/pixman/pixman-pict.c b/pixman/pixman-pict.c
index b8b7b76..c7d73fc 100644
--- a/pixman/pixman-pict.c
+++ b/pixman/pixman-pict.c
@@ -1778,7 +1778,6 @@ pixman_image_composite (pixman_op_t      op,
 		    break;
 		case PIXMAN_x8r8g8b8:
 		    switch (pDst->bits.format) {
-		    case PIXMAN_a8r8g8b8:
 		    case PIXMAN_x8r8g8b8:
 #ifdef USE_MMX
 			if (pixman_have_mmx())
@@ -1790,7 +1789,6 @@ pixman_image_composite (pixman_op_t      op,
 		    }
 		case PIXMAN_x8b8g8r8:
 		    switch (pDst->bits.format) {
-		    case PIXMAN_a8b8g8r8:
 		    case PIXMAN_x8b8g8r8:
 #ifdef USE_MMX
 			if (pixman_have_mmx())
--
1.5.2.2


--Multipart_Tue_Sep__4_17:25:52_2007-1
Content-Type: text/plain; charset=US-ASCII



--Multipart_Tue_Sep__4_17:25:52_2007-1--

--pgp-sign-Multipart_Tue_Sep__4_17:25:52_2007-1
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBG3feX6JDdNq8qSWgRAkOOAJsGprIjCQOA9/dYtu+bxk7uAoBbjQCeKROr
sHU66TNC5ulNgIk6+6ckDUM=
=Um+Z
-----END PGP SIGNATURE-----

--pgp-sign-Multipart_Tue_Sep__4_17:25:52_2007-1--


More information about the cairo mailing list