[cairo] infinite loop when CAIRO_FIXED_FRAC_BITS is 8

Behdad Esfahbod behdad at behdad.org
Sat Feb 16 23:07:50 PST 2008

On Sat, 2008-02-16 at 13:40 -0800, Carl Worth wrote:
> On Fri, 15 Feb 2008 11:52:19 -0500, Behdad Esfahbod wrote:
> > Ah.  The fix is still valid and should go in though.
> Yes, fair enough. It's still a good fix for _cairo_slope_compare.
> So here are two follow-on patches. The first simply eliminates some
> code as a cleanup, (I don't intend any functional change at all---so
> any review to verify that would be appreciated).

Looks right to me.

> Then, the second is as nice a fix as you could hope for I think. It
> simply changes a >= to a > and makes the infinite loop go away.
> Again, review is appreciated, but I'm feeling much more confident
> about this stuff now. It seems much more "obviously correct". Plus,
> I'm just plain excited to be ready to push out the next snapshot.

I'm not proficient in the stroker code, but the change looks quite safe
to say the least.

> -Carl
> PS. Behdad, I'm trying a different attachment method now, please let
> me know if it isn't kinder for your mailer. I was quite embarrassed to
> realize I'd been sending with an octet-stream mime tag. Hopefully now
> they'll all be nicely tagged as text/plain, (and UTF-8 as
> needed). Oddly enough, my mailer had always displayed the received
> things as plain text and let me comment on them by just clicking
> reply.

Yep, works great.  Evo shows them inline in fact.



"Those who would give up Essential Liberty to purchase a little
 Temporary Safety, deserve neither Liberty nor Safety."
        -- Benjamin Franklin, 1759

More information about the cairo mailing list