[cairo] [PATCH/pixman] Fix the SSE related AMD64 build breakage

Soeren Sandmann sandmann at daimi.au.dk
Mon Mar 17 12:05:38 PDT 2008

Nicholas Miell <nmiell at comcast.net> writes:

> >From 2527b35ff8eeacf9f42d529c12523f2c375295c8 Mon Sep 17 00:00:00 2001
> From: nmiell at gmail.com <Nicholas Miell>
> Date: Fri, 14 Mar 2008 22:23:19 -0700
> Subject: [PATCH] Fix the SSE related AMD64 build breakage
> The introduction of pixman_have_sse() copied the #ifdef __amd64__
> found around pixman_have_mmx() in pixman-mmx.c but didn't include the
> equivalents of the macros in pixman-mmx.h. As a result, the AMD64 link
> fails because the pixman_have_sse() function doesn't exist.

Is it actually correct to skip the runtime check on x86-64? I don't
think there is a guarantee that MMX will be supported forever. 

Also, is the optimization really worth it? It gets rid of one function
call at the expense of compile-time complexity leading to bugs like
this one.

The patch looks otherwise fine to me.


More information about the cairo mailing list