[cairo] More info about fbCompositeCopyAreammx

[Vladimir Vukicevic]

On Mar 27, 2008, at 2:53 PM, Frédéric Plourde wrote:
> Vladimir Vukicevic a écrit :
>>
>> On Mar 27, 2008, at 11:51 AM, Frédéric Plourde wrote:
>>> I'll investigate some more about that, but for now, I think the  
>>> patch "pixman_OPT_MMX_addFastPath_to_fbCompositeCopyAreammx.patch"  
>>> is worth it.
>>
>> Sounds good to me -- Soeren, adding an x8r8g8b8 -> a8r8g8b8 SOURCE  
>> path being a Copy sounds sane, right?  Fred, I notice that your  
>> patch only adds that path for the MMX case, but the same path can  
>> be added for non-MMX also, I think.

> By non-mmx, you mean the regular c_fast_paths, right ?... Then,   
> Yep, the optimization benefits there also, but it's been already  
> done in the past.
> The fastpath function name is not named consistently with the mmx  
> one though...
>
> see the
> { PIXMAN_OP_SRC, PIXMAN_a8r8g8b8,  PIXMAN_null,     PIXMAN_x8r8g8b8,  
> fbCompositeSrc_8888xx888, 0 }, and
> { PIXMAN_OP_SRC, PIXMAN_a8b8g8r8,  PIXMAN_null,     PIXMAN_x8b8g8r8,  
> fbCompositeSrc_8888xx888, 0 }, in pixman-pict.c
> which both call function "fbCompositeSrc_8888xx888" that simply does  
> the trick using memcpy(...) ;-)

Ah ha, yeah, I didn't look and see exactly what that function did :)

    - Vlad