[cairo] User-fonts landed
Behdad Esfahbod
behdad at behdad.org
Tue May 13 09:46:52 PDT 2008
On Mon, 2008-05-12 at 17:59 -0400, Kristian Høgsberg wrote:
> On Fri, May 9, 2008 at 7:24 PM, Behdad Esfahbod <behdad at behdad.org> wrote:
> > Just pushed 40 commits, landing all the user-font stuff I had. Will
> > look in the following issues in the coming days:
> >
> > - Documenting new API
> > - Testing user-fonts using other fonts
> > - Figuring out what to do with font options (non-AA, subpixel, metrics
> > hinting)
> > - Peter's issues
> >
> > That's all for now. Review appreciated.
>
> Great work, thanks, I'm happy to see that this is finally in :) I
> looked through the patches briefly and caught this:
>
> +#define STROKE 13
> +#define CLOSE 14
>
> Those defines should be bumped now that you've add a baseline to the
> grid. In the example font no glyphs actually have points below the
> baseline, so it works by accident. I recommend
>
> #define STROKE 126
> #define CLOSE 127
>
> And adding a few glyphs with points below the baseline would probably
> be a nice idea.
Thanks Kristian. Did that, and found a bug with my traps_path().
Fixing that and then I'll push.
Jeff, did you start looking into the Poppler patch yet?
> cheers,
> Kristian
--
behdad
http://behdad.org/
"Those who would give up Essential Liberty to purchase a little
Temporary Safety, deserve neither Liberty nor Safety."
-- Benjamin Franklin, 1759
More information about the cairo
mailing list