[cairo] GSoC: Scan converting rasteriser update

Jeff Muizelaar jeff at infidigm.net
Tue Nov 4 13:13:35 PST 2008

On Wed, Oct 29, 2008 at 06:43:04PM +0200, M Joonas Pihlaja wrote:
> I hope the new spans-pruning branch proves easier to review now 
> that there's less irrelevant clutter in there.

Here's a review of the path-fixed changes:

    [path-fixed] Avoid extra indirection when iterating already flat paths.
     - looks good
    [path-fixed] New _cairo_path_fixed_is_region().
     - could test path has curve_to and fail immediately on that?

    [path-fixed] New _cairo_path_fixed_bounds_approximate_box().
     - perhaps give the reason for wanting bounds_approximate_box
     - _cairo_path_fixed_bounds_approximate_box should have some
       documentation about what it computes. i.e. what the approximation is
     - it looks like _cairo_path_fixed_interpret can't fail, so we technically
       don't need to deal with the failure case. Perhaps we should actually
       assert on failure...


More information about the cairo mailing list