[cairo] [PATCH] Restore glitz-surface-source test
chris at chris-wilson.co.uk
Wed Nov 26 09:09:09 PST 2008
On Wed, 2008-11-26 at 16:12 +0100, Paolo Bonzini wrote:
> Hi all,
> the glitz-surface-source test is currently disabled. The attached patch
> adds support for the AGL backend (in theory you'd have separate tests
> for each backend) and adds the missing PostScript reference images that
> are needed for it to pass. It can be applied with "git am" (it includes
> file copies).
> Ok? Can it be committed for me?
Pushed all 3 patches - though I had to add commentary for the 'why' part
of the commit log.
Carl's guidelines for the change log is a single line header to describe
what changed followed by a paragraph (or more depending upon the
complexity) of why. Even for a simple compile fix, taking the time to
explain why the fix is needed is useful for other developers reading the
commit log. And the second aspect of the change log is that in a few
months time, Carl will need to read through the changes and produce a
summary of our brilliance for the NEWS and release announcements.
An addendum to those basic principles, we have evolved a system of
[subsystem] Summary of change
for the single line header, which helps when scanning through the logs.
More information about the cairo