[cairo] Reading rdtsc on x86_64

Carl Worth cworth at cworth.org
Wed Sep 24 13:18:07 PDT 2008


On Fri, 2008-09-12 at 10:35 +0200, Soeren Sandmann wrote:
> M Joonas Pihlaja <jpihlaja at cc.helsinki.fi> writes:
> 
> > The oil_profile_stamp_rdtsc() function uses the =A mode to read
> > the 64 bit result of rdtsc on both x86 and x86_64.  This doesn't
> > work on x86_64 reliably as we want to be reading eax:edx, but
> > with =A we're reading a single 64 bit register instead.
> > 
> > I've been using the attached patch at home.  Someone look it
> > over?
> 
> Looks good to me - in fact, I don't see any reason it wouldn't also
> work on x86-32, so it could probably simply replace the old one.

Joonas,

You got review and confirmation here. Any reason this patch didn't get
pushed?

-Carl
 



More information about the cairo mailing list