[cairo] [cairo-commit] src/cairo.h src/cairo-scaled-font.c src/cairo-user-font.c

[Behdad Esfahbod]

Carl Worth wrote:
> On Mon, 2008-09-29 at 08:34 -0700, Behdad Esfahbod wrote:
>> New commits:
>> commit 1310df44edcf0b9fee648c8f8688d4a1177cde68
>> Author: Behdad Esfahbod <behdad at behdad.org>
>> Date:   Mon Sep 29 11:34:19 2008 -0400
>>
>>     [text_to_glyphs] Further enhance the docs
>>     
>>     The most complex public cairo API deserves more doc love...
> ...
>>  	if (*num_glyphs < 0) {
>> +	    if (orig_glyphs != *glyphs) {
>> +		cairo_glyph_free (*glyphs);
>> +		*glyphs = orig_glyphs;
>> +	    }
>>  	    *num_glyphs = orig_num_glyphs;
>>  	    return CAIRO_INT_STATUS_UNSUPPORTED;
>>  	}
> 
> This code-change hunk obviously wasn't included in the commit-message,

Um, sorry, I just saw it after I read the commit mail.

> (and clearly wasn't intentional as part of the commit).

Could go as a separate commit, yeah.  I was cross-referencing the docs and the
implementation and noted that I can be more pedantic there (since the other
side of this code can be a user-font text_to_glyphs that doesn't quite clean
after itself...)

> Still correct though? (Looks like it to me.)

Yes.

behdad

> -Carl
> 
> 
>