[cairo] [PATCH] pixman: Implement PIXMAN_REPEAT_REFLECT for images

Thomas Jaeger thjaeger at gmail.com
Thu Jan 22 00:22:37 PST 2009


Sorry, I missed a special case that is present in git but not in 0.13.2.
An updated patch is attached.

Thomas Jaeger wrote:
> In the case of EXTEND_REFLECT, it won't work at all unless the driver
> accelerates it, since pixman currently doesn't have support for REFLECT
> at all.  I've attached a patch that addresses the issue (hope this is
> the right mailing list).  Caveats: I wasn't familiar with the pixman
> source.  When it didn't work right away after changing
> pixman-transformed.c, I simply made sure that REFLECT uses the same path
> as PAD everywhere.  This isn't very well-tested (I basically just tested
>  [2]) and there's probably room for optimization, but I doubt REFLECT is
> used very much anyway.
> 
> 
> Zack Weinberg wrote:
>> ... because whether or not Render's equivalent of
>> EXTEND_PAD/EXTEND_REFLECT actually *work* is dependent on the exact
>> version of your X server and video drivers.  Render protocol 0.10 isn't
>> good enough.  There are some cairo-only test cases in [2].
>>
>> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=468496
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implement-PIXMAN_REPEAT_REFLECT-for-images.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20090122/cd2c197f/attachment.bin 


More information about the cairo mailing list