[cairo] Comments on NEON code

[Soeren Sandmann]

Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:

> At least for linux, in the recent kernels A bit is unconditionally
> disabled (arch/arm/mm/alignment.c), and hopefully will stay this way
> forever. But even if not (or if pixman is run on some other OS, which has
> different setup), then this is not a problem for NEON too, see
> below.

Thanks for this explanation.

> > - Naming: 24x16, not 0888x0565?
> >
> > Is there any reason to not follow the same naming convention as
> > elsewhere? And if there is, why not do it consistently? Otherwise,
> > it's just a gratuitous inconsistency that will leave the next person
> > reading the code wondering what the significance of this change is.
> 
> By the way, I always wondered about the names like 'fbCompositeSrc_8888x0565'.
> Why 'Src', while it is definitely OVER operation?

I think it was just a mistake in the original set of fast paths that
has since propagated by cut and paste. It's fixed in this branch:

    http://cgit.freedesktop.org/~sandmann/pixman/log/?h=naming

Specifically this commit:

    http://cgit.freedesktop.org/~sandmann/pixman/commit/?h=naming&id=3c637d17b3334ef64600738c264c853c0a1a59f3

The naming branch is one the final pieces of the refactoring. I plan
to merge it soon.


Soren