[cairo] pixman "Simplify clipping rule" problems

Siarhei Siamashka siarhei.siamashka at gmail.com
Sun Jul 12 05:40:21 PDT 2009


On Friday 10 July 2009, Soeren Sandmann wrote:
> Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:
> > The one thing that worries me a bit is that apparently (almost) nobody
> > else is using 'scaling-test' program. As limited as it is, it could have
> > prevented a handful of broken commits already. And you can't rely on me
> > monitoring this mailing list forever, effectively working as a trained
> > monkey who just runs the test program occasionally and complains when
> > something gets obviously broken. Seriously, should we add some 'make
> > test' target with an easily interpretable result and ask commiters to
> > reject any patches which make it fail unless this failure is investigated
> > and properly explained?
>
> Yes, such a target would be very useful, and I would certainly make
> sure it passed before making releases. Some of the other test programs
> could be run as well - generally the one that don't use GTK+. They
> generally use assert() to check that things look right.

Would something like the attached patch be good for this?

Both scaling-test and blitters-test can be also modified to have not one, but 
two crc checkpoints. The first one coming much earlier (after just 1-2
seconds on typical hardware), so that obvious problems in the code can be
spotted with much lower number of iterations, saving time when debugging.

-- 
Best regards,
Siarhei Siamashka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-New-make-test-target-for-running-pixman-regression.patch
Type: text/x-diff
Size: 986 bytes
Desc: not available
Url : http://lists.cairographics.org/archives/cairo/attachments/20090712/39095ae5/attachment.patch 


More information about the cairo mailing list