[cairo] [PATCH] Another set of NEON blitters for Pixman.

Jeff Muizelaar jeff at infidigm.net
Mon Jun 15 11:30:29 PDT 2009


On Mon, Jun 15, 2009 at 04:43:52PM +0300, Jonathan Morton wrote:
> On Mon, 2009-06-15 at 15:15 +0300, Jonathan Morton wrote:
> > > > The 0006 patch doesn't seem to apply. What are you using to generate the
> > > > patches, I've had trouble applying them. git format-patch might be a
> > > > good choice.
> > > 
> > > That *is* from git format-patch.  But maybe the tree has diverged
> > > sufficiently since I made the patches, since they've been sitting in
> > > your queue for a week or so.
> > > 
> > > Let me see if I can fix anything.
> > 
> > Okay, it's possible that lack of rebasing was the cause.  (If it wasn't
> > obvious, I'm still getting to grips with git and it's quirks.)
> > 
> > If you want nice little patches, I'll have to do more work.  For now,
> > can you see if this big one applies?  It brings the current tree up to
> > date with what I use myself.
> 
> Here's a better series of smaller patches, which deal with one thing at
> a time.
> 
> This lot has been tested to apply against a fresh clone of the pixman
> git repo, so you should have no trouble.  It seems that even git can
> fall over it's own feet when making patches, though.
> 

Yep, this set applies just fine, thanks.

I've pushed everything up to RCVT straight blitter support patch.
I should've asked earlier, but I was wondering if you could explain why
your fbCompositeSolidMask_nx8x0565neon is about 2x faster. It will be
good to have this info in the commit message.

-Jeff


More information about the cairo mailing list